Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use M256 (set brightness) instead of M250 (set contrast) #263

Closed
4 tasks done
andrivet opened this issue Oct 1, 2021 · 1 comment
Closed
4 tasks done

Use M256 (set brightness) instead of M250 (set contrast) #263

andrivet opened this issue Oct 1, 2021 · 1 comment
Labels
bug A bug (confirmed or not yet confirmed)
Milestone

Comments

@andrivet
Copy link
Owner

andrivet commented Oct 1, 2021

Bug Report

  • You have checked that you are not creating a duplicate of an existing (maybe closed) issue (use the search)
  • You have tested with the latest stable version of ADVi3++
  • You are able to reproduce the bug
  • You are able to describe step by step the process to reproduce the bug

Description of the bug

  • Exact model of your printer: Wanhao Duplicator i3 Plus
  • ADVi3++ exact version (Mainboard): 5.0.1
  • Printing using SD card or USB: n/a
  • Do you use a BLTouch?: n/a
  • Expected behaviour: M256 should set the brightness of the LCD panel
  • Actual behaviour: Instead, you have to use M250
  • Steps to reproduce:
    • M250 C20 set the brightness
    • M256 B20 is not defined (error)

Note: M256 was added recently (MarlinFirmware/Marlin#22478) so not really a bug, but M256 is better than M250.

@andrivet andrivet added the bug A bug (confirmed or not yet confirmed) label Oct 1, 2021
@andrivet andrivet added this to the 5.1 milestone Mar 22, 2022
@andrivet
Copy link
Owner Author

Implemented in version 5.1

@andrivet andrivet changed the title Define M250 (set contrast) instead of M256 (set brightness) Use M256 (set brightness) instead of M250 (set contrast) Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug (confirmed or not yet confirmed)
Projects
None yet
Development

No branches or pull requests

1 participant