Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include CSS in component so user do not have to import it manually #11

Closed
GauthierPLM opened this issue Jan 9, 2020 · 2 comments
Closed

Include CSS in component so user do not have to import it manually #11

GauthierPLM opened this issue Jan 9, 2020 · 2 comments
Assignees
@andrewvasilchuk
Labels
good first issue Good for newcomers

Comments

@GauthierPLM
Copy link

GauthierPLM commented Jan 9, 2020 •
edited by andrewvasilchuk
Loading

The CSS should be imported in the component directly, so the user do not have to import it manually.

Currently, the component will not work if CSS is not imported in addition to the component. Moreover, this is not explained in the README.
@andrewvasilchuk
Copy link
Owner

@GauthierPLM, Thanks. It's by design. Currently rollup-plugin-vue does not support correct build for SSR. If we insert styles directly into component, an SSR build will be completely broken, so we are forced tom move styles to the separate file, and bundle them independently. Skim through this issue.

@andrewvasilchuk
Copy link
Owner

@GauthierPLM, There is a separate section about styles.

@andrewvasilchuk andrewvasilchuk self-assigned this Jan 18, 2020
@andrewvasilchuk andrewvasilchuk added the good first issue Good for newcomers label Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewvasilchuk andrewvasilchuk

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GauthierPLM @andrewvasilchuk