Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pydantic 2.7.1 PR #225

Merged
merged 25 commits into from
May 16, 2024

Conversation

actuarysailor
Copy link
Contributor

@actuarysailor actuarysailor commented May 7, 2024

Upgrading all code to reference pydantic 2.7.1; from pydantic 1.10.9

@actuarysailor
Copy link
Contributor Author

@andrewthetechie - I can't run the nox tests on windows. For some reason, however you have it configured, it keeps saying nox cannot find the session bandit even if I try to manually create it or other things. Can you add some instructions on how to setup the nox sessions for using your repo?

@andrewthetechie
Copy link
Owner

Try rebasing on the main branch; there was an error in the noxfile.

I can't really provide any specific instructions on running on windows - I don't have a windows machine to test on. Nox is supposed to "just work" on different platforms which is why I use it.

You can also run specific sessions with nox, so to run only the tests locally, you can run nox -s tests.

@actuarysailor actuarysailor marked this pull request as ready for review May 13, 2024 18:23
@actuarysailor
Copy link
Contributor Author

Try rebasing on the main branch; there was an error in the noxfile.

I can't really provide any specific instructions on running on windows - I don't have a windows machine to test on. Nox is supposed to "just work" on different platforms which is why I use it.

You can also run specific sessions with nox, so to run only the tests locally, you can run nox -s tests.

@andrewthetechie - never got it to work on windows, but was able to learn what changed in pedantic 2.0: basically, instead of the values being values, it is now validation info, so you need to do var.data instead of var for dictionary.

@actuarysailor actuarysailor changed the title feat: Pydantic 2.0 PR feat: Pydantic 2.7.1 PR May 13, 2024
@actuarysailor
Copy link
Contributor Author

@andrewthetechie - any thoughts?

@andrewthetechie andrewthetechie merged commit c1e014a into andrewthetechie:main May 16, 2024
7 checks passed
@andrewthetechie
Copy link
Owner

@actuarysailor unfortunately, this looks like it broke on merging to master and running the integration testing https://github.com/andrewthetechie/gha-repo-manager/actions/runs/9104763824/job/25029195967

I'll try to take a look at fixing this, but might not get to it until this weekend.

@andrewthetechie
Copy link
Owner

@actuarysailor I was able to fix the action integration test, but had to undo some of your changes - they were causing it to not run on the right target (it was always cloning main, was missing env vars, it just wasn't working at all).

I also had to make some code changes, please rebase your other prs on the main branch.

Unfortunately ,the action integration test just might not work on your PRs. I'll have to check it after a PR merges and correct any issues.

@actuarysailor actuarysailor deleted the feat/pydantic2.0 branch May 30, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants