Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show avro schema id #405

Merged
merged 2 commits into from
Mar 5, 2023
Merged

feat: show avro schema id #405

merged 2 commits into from
Mar 5, 2023

Conversation

andrewinci
Copy link
Owner

@andrewinci andrewinci commented Mar 5, 2023

  • Show the schema version id in the record detail modal
  • Add shortcut from the record detail modal to the schema version used to deserialise the record
  • WIP: surface record size and header for the kafka records

Closes #403

@andrewinci andrewinci marked this pull request as ready for review March 5, 2023 09:08
@andrewinci andrewinci enabled auto-merge (squash) March 5, 2023 09:18
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Merging #405 (5701490) into main (630a80e) will decrease coverage by 0.22%.
The diff coverage is 32.25%.

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   53.43%   53.21%   -0.22%     
==========================================
  Files         113      113              
  Lines        5925     5968      +43     
  Branches      292      294       +2     
==========================================
+ Hits         3166     3176      +10     
- Misses       2736     2769      +33     
  Partials       23       23              
Impacted Files Coverage Δ
backend/src/core/parser/mod.rs 0.00% <0.00%> (ø)
frontend/src/main.tsx 0.00% <0.00%> (ø)
frontend/src/models/kafka.ts 0.00% <0.00%> (ø)
...tend/src/pages/topics/modals/record-view-modal.tsx 0.00% <0.00%> (ø)
backend/src/core/avro/avro_to_json.rs 93.54% <100.00%> (ø)
backend/src/core/record_store/sqlite_store.rs 96.36% <100.00%> (+0.95%) ⬆️
frontend/src/components/new-window-button.tsx 100.00% <100.00%> (ø)
frontend/src/pages/schema-registry/schema.tsx 98.96% <100.00%> (+0.09%) ⬆️
backend/src/core/record_store/topic_store.rs 74.69% <0.00%> (-1.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrewinci andrewinci merged commit 605861f into main Mar 5, 2023
@andrewinci andrewinci deleted the show_avro_schema_id branch March 5, 2023 09:27
andrewinci pushed a commit that referenced this pull request Mar 5, 2023
# [2.12.0](v2.11.2...v2.12.0) (2023-03-05)

### Bug Fixes

* de-duplicate notifications ([40fadf0](40fadf0))

### Features

* show avro schema id ([#405](#405)) ([605861f](605861f))
* show raw record size ([#406](#406)) ([feebfdd](feebfdd))
@andrewinci
Copy link
Owner Author

🎉 This PR is included in version 2.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display schema version with message
1 participant