Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C16 Symbol missing sword tip and pommel #246

Closed
HexOoze opened this issue Oct 19, 2024 · 1 comment
Closed

C16 Symbol missing sword tip and pommel #246

HexOoze opened this issue Oct 19, 2024 · 1 comment
Assignees
Labels
bug issues that require immediate attention

Comments

@HexOoze
Copy link

HexOoze commented Oct 19, 2024

The actual symbol on the C16 cards looks like this:
AC16
(from scryfall)
IAC16
It doesn't seem right whether gradient on or not.

@andrewgioia andrewgioia self-assigned this Oct 26, 2024
@andrewgioia andrewgioia added the bug issues that require immediate attention label Oct 26, 2024
@andrewgioia
Copy link
Owner

This is a great catch, it has to do with the "layer" of the set symbol used for the rarity gradient vs the layer used for the border. In this case, the rarity is the inner shield portion and all of the black is the border.

Whenever the new version of Keyrune releases this is properly handled with multiple glyphs, but for now we need to decide which layer gets to be the rarity layer. In this case it came out weird and you're right, the sword should be present in the symbol.

Common symbols sometimes reverse this, like you can see in Command Tower. The white layer in that symbol is the "rarity" layer and the inside black becomes the border ( which is red here). That white layer makes more sense if we have to pick one and we can definitely replace that in one of the next versions 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues that require immediate attention
Projects
None yet
Development

No branches or pull requests

2 participants