Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sluggish crosshair after dynamic updates #138

Open
carlos8f opened this issue Aug 17, 2016 · 8 comments
Open

Sluggish crosshair after dynamic updates #138

carlos8f opened this issue Aug 17, 2016 · 8 comments
Labels
improvement
Milestone
0.9.0

Comments

@carlos8f
Copy link
Contributor

Great library! Works well, except for sluggish performance after a while. Tried hardware acceleration on and off. Any advice would be appreciated.

https://zenbot.s8f.org/
@andredumas
Copy link
Owner

That's an interesting one. I observed the issue on that site, but when I attempt to inspect it becomes performant, even if i'm careful not to cause a redraw. Would be helpful if you could provide sample code of the isolated issue and any specific observations.

Nice color scheme btw

@carlos8f
Copy link
Contributor Author

yeah, it's odd. Will see if I can reproduce the issue with minimal code. Thanks.

@carlos8f
Copy link
Contributor Author

carlos8f commented Aug 18, 2016 •
edited
Loading

Page to reproduce the issue: http://bl.ocks.org/carlos8f/raw/ac8677ff6f6432b87b4d7fed25931e7d/

Minimal 2-line fix (disable scale() and differencePath()): http://bl.ocks.org/carlos8f/raw/346f1030d1aaa1d5ba635cc67452214d/

CPU profile: https://gist.github.com/carlos8f/8a0d617739f35f7aa7a9af064c9fc76c#gistcomment-1852166

working on this at https://gist.github.com/carlos8f/8a0d617739f35f7aa7a9af064c9fc76c

@carlos8f
Copy link
Contributor Author

There's a perf. bottleneck in the scale() function. https://gist.github.com/carlos8f/8a0d617739f35f7aa7a9af064c9fc76c#gistcomment-1852195

@carlos8f carlos8f mentioned this issue Aug 18, 2016
Merged
carlos8f pushed a commit to DeviaVir/zenbot that referenced this issue Aug 18, 2016
techan.js perf patch, see andredumas/techan.js#138
c1f0cf0
@carlos8f
Copy link
Contributor Author

carlos8f commented Aug 18, 2016 •
edited
Loading

Sluggish issue is still present after patch, although my CPU profiler is no longer showing scale() as bottleneck

@andredumas
Copy link
Owner

Nice pick up! Will give the pr a try see if it fixes for me.

Thank you.

@andredumas
Copy link
Owner

Sluggish issue is still present after patch

Still a problem then?

@andredumas andredumas added the bug label Aug 22, 2016
@andredumas andredumas added this to the 0.7.0 milestone Aug 22, 2016
@carlos8f
Copy link
Contributor Author

still a problem after those date/string optimizations, just takes slightly longer to accumulate slowness.

andredumas added a commit that referenced this issue Aug 25, 2016
@andredumas
refs #139, #138: Performance based changes - financetime instanceof, …
4931606 
…string constructor removal, remove Array.join

* Adding financetime tests to ensure scale of null and undefined are handled gracefully
* Removing String constructor, profiling appears quicker without
* Removing usage of Array.join. Array.join is very slow in chrome
@andredumas andredumas modified the milestones: 0.7.0, 0.8.0, 0.9.0 Sep 26, 2016
supersabbath pushed a commit to supersabbath/zenbot that referenced this issue Oct 2, 2017
techan.js perf patch, see andredumas/techan.js#138
30fd14e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
2 participants
@carlos8f @andredumas