Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix OSError on spawning of PtyProcess #88

Merged
merged 1 commit into from
Jan 27, 2018
Merged

PR: Fix OSError on spawning of PtyProcess #88

merged 1 commit into from
Jan 27, 2018

Conversation

dalito
Copy link
Contributor

@dalito dalito commented Jan 24, 2018

Let the socket library pick a free port. This avoid errors resulting from binding a socket to a port that is still in wait state.

Fixes #86

Let the socket library pick a free port. This avoid errors resulting from binding a socket to a port that is still in wait state.

Fixes #86
@ccordoba12 ccordoba12 added this to the v0.5.2 milestone Jan 24, 2018
@ccordoba12
Copy link
Contributor

So there's no need now to add the delay you had before?

@dalito
Copy link
Contributor Author

dalito commented Jan 24, 2018

Exactly!

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ccordoba12 ccordoba12 changed the title Fix OSError on spawning of PtyProcess PR: Fix OSError on spawning of PtyProcess Jan 27, 2018
@ccordoba12 ccordoba12 merged commit c3d2b3c into andfoy:master Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants