Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't replace : with - in docker SPDX namespaces #1111

Closed
aethanol opened this issue Jul 20, 2022 · 1 comment · Fixed by #1347
Closed

Don't replace : with - in docker SPDX namespaces #1111

aethanol opened this issue Jul 20, 2022 · 1 comment · Fixed by #1347
Assignees
Labels
bug Something isn't working

Comments

@aethanol
Copy link

What would you like to be added:
In #649, https://github.com/anchore/syft/blob/main/internal/formats/common/spdxhelpers/document_name.go#L26 was introduced which replaces : with - in namespaces. This impacts the output name of docker SPDX.
Ideally these docker names like IMAGE[:TAG|@DIGEST] would be the same as outputted by syft.

Why is this needed:
We are having to manually parse this on ingestion time, back to : so we can correlate docker images with their syft scans.

@aethanol aethanol added the enhancement New feature or request label Jul 20, 2022
@kzantow kzantow added this to OSS Nov 14, 2022
@kzantow kzantow added bug Something isn't working and removed enhancement New feature or request labels Nov 17, 2022
@kzantow kzantow moved this to Backlog (Pulled Forward for Priority) in OSS Nov 17, 2022
@kzantow
Copy link
Contributor

kzantow commented Nov 17, 2022

For document name, we should not be "cleaning" the name -- it is a raw string. Check the following functions, it looks like we should NOT be calling cleanName:

@spiffcs spiffcs self-assigned this Nov 17, 2022
@spiffcs spiffcs moved this from Backlog (Pulled Forward for Priority) to In Progress (Actively Resolving) in OSS Nov 17, 2022
Repository owner moved this from In Progress (Actively Resolving) to Done in OSS Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants