Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically merge compatible PhysBones. #1292

Open
GotoFinal opened this issue Oct 24, 2024 · 1 comment
Open

Automatically merge compatible PhysBones. #1292

GotoFinal opened this issue Oct 24, 2024 · 1 comment
Labels
a:TraceAndOptimize issues about TraceAndOptimize features enhancement New feature or request

Comments

@GotoFinal
Copy link

GotoFinal commented Oct 24, 2024

I know there is a component to merge PhysBones, and it also need some improvements #895
But I wanted to suggest also integrating it into main optimization step, when bones are next to each other and all their values are the same, and they can't be grabbed, maybe they could be merged automatically. As far as I understand, there is no difference in behavior for these cases.

(I might try to make PR some other week if you are interested in the feature overall)

image

GPT 4:
隣接するボーンで、すべての値が同じで、かつ掴むことができない場合に、それらを自動的に結合するように、メインの最適化ステップに統合することを提案したいと思っています。理解している限りでは、これらのケースでの動作に違いはないようです。また、PhysBonesを結合するコンポーネントが存在し、それにも改良が必要であることは知っています。#895

@anatawa12 anatawa12 added enhancement New feature or request a:TraceAndOptimize issues about TraceAndOptimize features labels Oct 25, 2024
@anatawa12
Copy link
Owner

anatawa12 commented Oct 25, 2024

Thank you for creating feature request and looking for implementing feature.

I'm interested in the feature and I have it in mind to implement such a feature in the future, but I forgot to create issue.

But I wanted to suggest also integrating it into main optimization step, when bones are next to each other and all their values are the same, and they can't be grabbed, maybe they could be merged automatically. As far as I understand, there is no difference in behavior for these cases.

I think so but I have to consider PhysBone Chain length and Parameter setting in Options section.

Duplicated Parameter setting may work weirdly so I think we should not merge if Parameter setting is there.

Also, if any of PhysBone settings is using curve setting, we have to consider PhysBone Chain Length.
If PhysBone Chain Length is different, the frame (time) PhysBone pick from curve is different between PhysBone so it must be same to work correctly.
(I didn't know that at the time so I did not make error in MergePhysBone but for now there will be warning in that case.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:TraceAndOptimize issues about TraceAndOptimize features enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants