From b025a4737e0bb624c3eec2d80abe4cecf9db0cea Mon Sep 17 00:00:00 2001 From: hitsub Date: Tue, 13 Jun 2023 18:13:59 +0900 Subject: [PATCH 1/3] fix: dropping PhysBone to MergePhysBone is not working --- Editor/MergePhysBoneEditor.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Editor/MergePhysBoneEditor.cs b/Editor/MergePhysBoneEditor.cs index 6bf6ecd6b..f0bd62f07 100644 --- a/Editor/MergePhysBoneEditor.cs +++ b/Editor/MergePhysBoneEditor.cs @@ -32,6 +32,8 @@ protected override void OnInspectorGUIInner() EditorGUILayout.PropertyField(_componentsSetProp); + serializedObject.ApplyModifiedProperties(); + // draw custom editor _renderer.DoProcess(); From 62eabad34c1eb94f3ae6d4a2c09f10ca575e617f Mon Sep 17 00:00:00 2001 From: anatawa12 Date: Tue, 13 Jun 2023 22:05:31 +0900 Subject: [PATCH 2/3] docs(changelog): add Dropping PhysBone to MergePhysBone is not working --- CHANGELOG-PRERELEASE.md | 1 + CHANGELOG.md | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG-PRERELEASE.md b/CHANGELOG-PRERELEASE.md index 70a682711..e4f8c4a2d 100644 --- a/CHANGELOG-PRERELEASE.md +++ b/CHANGELOG-PRERELEASE.md @@ -16,6 +16,7 @@ The format is based on [Keep a Changelog]. ### Removed ### Fixed +- Dropping PhysBone to MergePhysBone is not working `#221` ### Security diff --git a/CHANGELOG.md b/CHANGELOG.md index 84a813752..293bfabec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ The format is based on [Keep a Changelog]. ### Removed ### Fixed +- Dropping PhysBone to MergePhysBone is not working `#221` ### Security From 990ad54d8ff341a37340167cefb9f3b8e9659d92 Mon Sep 17 00:00:00 2001 From: anatawa12 Date: Tue, 13 Jun 2023 22:19:27 +0900 Subject: [PATCH 3/3] chore: add comment about ApplyModifiedProperties --- Editor/MergePhysBoneEditor.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Editor/MergePhysBoneEditor.cs b/Editor/MergePhysBoneEditor.cs index f0bd62f07..426edfa91 100644 --- a/Editor/MergePhysBoneEditor.cs +++ b/Editor/MergePhysBoneEditor.cs @@ -32,6 +32,8 @@ protected override void OnInspectorGUIInner() EditorGUILayout.PropertyField(_componentsSetProp); + // on DragPerform, in DoProcess, new HelpBox invocation throws ExitGUIException + // so I ApplyModifiedProperties here. serializedObject.ApplyModifiedProperties(); // draw custom editor