From 1de8be6ad21ae0a056dbe62322b89ef7db610a48 Mon Sep 17 00:00:00 2001 From: "Qingyang(Abby) Hu" Date: Mon, 6 Nov 2023 17:34:06 -0800 Subject: [PATCH] Fix navigation bug from dashboard to dashboard (#5435) Previously navigating from one dashboard to another dashboard do not work. This PR adds a dashboard id as a prop to pass into the component in order to force react to re-render every time it receives a new id. Resolve the following issues: * https://github.com/opensearch-project/OpenSearch-Dashboards/issues/4694 * https://github.com/opensearch-project/Open and Search-Dashboards/issues/4819 Signed-off-by: abbyhu2000 --- CHANGELOG.md | 1 + .../public/application/embeddable/dashboard_container.tsx | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2457b2a1cc7a..5a764c376d1a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -75,6 +75,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - [BUG][Fuctional Test] Make setDefaultAbsoluteRange more robust and update doc views tests ([#5242](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5242)) - [BUG] Add platform "darwin-arm64" to unit test ([#5290](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5290)) - [BUG][Dev Tool] Add dev tool documentation link to dev tool's help menu [#5166](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5166) +- Fix navigation issue across dashboards ([#5435](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5435)) ### 🚞 Infrastructure diff --git a/src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx b/src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx index dad2f196f1b8..d994e98142db 100644 --- a/src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx +++ b/src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx @@ -239,6 +239,7 @@ export class DashboardContainer extends Container