Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite-plugin-angular): add include configuration for analog file globs #882

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

joshuamorony
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Currently the glob used to find analog files only searches from the root of the application, this means in a workspace with multiple projects analog files outside of the application directory won't be found/compiled

Closes #

What is the new behavior?

Add a configuration to supportAnalogFormat to allow supplying additional globs that will be applied from the workspace root. This will allow specifying specific libraries/directories to find analog files in as well as the app directory which is included by default.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 363974d
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/65c5637a6dea68000868047b
😎 Deploy Preview https://deploy-preview-882--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 363974d
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/65c5637aea17c7000831c2b3
😎 Deploy Preview https://deploy-preview-882--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 363974d
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/65c5637a8f25720008dae77d
😎 Deploy Preview https://deploy-preview-882--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 363974d
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/65c5637a3e7d1d0008661b06
😎 Deploy Preview https://deploy-preview-882--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 00baaf4 into analogjs:main Feb 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants