Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): add SSR support for rxfire packages #851

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

[vite] Error when evaluating SSR module /src/app/pages/home.page.ts: failed to import "rxfire/auth"
t "rxfire/auth"
|- **/node_modules/rxfire/auth/index.esm.js:1
import { onAuthStateChanged, onIdTokenChanged, getIdToken } from 'firebase/auth';
^^^^^^

Closes #

What is the new behavior?

rxfire libraries can be imported using SSR without error

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 4ad734b
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/65a0bca81f33b80008a9ae4d
😎 Deploy Preview https://deploy-preview-851--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 4ad734b
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/65a0bca82048420008dd9026
😎 Deploy Preview https://deploy-preview-851--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 4ad734b
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/65a0bca89801190009bf21b7
😎 Deploy Preview https://deploy-preview-851--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 4ad734b
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/65a0bca98d077a000810e710
😎 Deploy Preview https://deploy-preview-851--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 7a96faa into main Jan 12, 2024
22 of 23 checks passed
@brandonroberts brandonroberts deleted the fix-rxfire-ssr branch January 12, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant