Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite-plugin-nitro): prerender content dir routes #833

Merged

Conversation

d-koppenhagen
Copy link
Contributor

@d-koppenhagen d-koppenhagen commented Jan 3, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #820

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit da83aff
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/65a573a5ba777000085c1dce
😎 Deploy Preview https://deploy-preview-833--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit da83aff
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/65a573a5ba777000085c1dcc
😎 Deploy Preview https://deploy-preview-833--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit da83aff
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/65a573a54766530008ed61f2
😎 Deploy Preview https://deploy-preview-833--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts
Copy link
Member

@d-koppenhagen I think this is on the right track. Will you check on the build failures?

image

@d-koppenhagen d-koppenhagen force-pushed the feat/prerender-content-dir-routes branch from 1ea744a to 7f30913 Compare January 8, 2024 07:42
Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit da83aff
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/65a573a5aac0370008725f99
😎 Deploy Preview https://deploy-preview-833--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@d-koppenhagen d-koppenhagen force-pushed the feat/prerender-content-dir-routes branch 3 times, most recently from 4142d21 to 91b3e27 Compare January 8, 2024 20:02
@d-koppenhagen d-koppenhagen marked this pull request as ready for review January 8, 2024 21:00
@d-koppenhagen
Copy link
Contributor Author

@brandonroberts I refactored it a bit and added also some more documentation and fixed the tests. It should now work as expected.

@d-koppenhagen d-koppenhagen changed the title feat: pre-render content dir routes (WIP) feat: pre-render content dir routes Jan 8, 2024
@brandonroberts
Copy link
Member

@d-koppenhagen there are lots of files changed that aren't necessary for this PR. Any idea what happened there?

@d-koppenhagen
Copy link
Contributor Author

I had run prettier as a GitHub action was red since formatting was not ok.
It's a separate commit.
I can revert it and cleanup my commits a bit.

@d-koppenhagen d-koppenhagen force-pushed the feat/prerender-content-dir-routes branch from bb1cc7b to 7129395 Compare January 9, 2024 05:22
@d-koppenhagen
Copy link
Contributor Author

d-koppenhagen commented Jan 9, 2024

I think a big part of the changed files are the ones of the blog demo app which I updated to demo the new feature here.

@d-koppenhagen d-koppenhagen force-pushed the feat/prerender-content-dir-routes branch 3 times, most recently from e961de6 to e58f29c Compare January 13, 2024 05:34
@d-koppenhagen
Copy link
Contributor Author

@brandonroberts sorry it took a while but now the build and format etc. is green.

@d-koppenhagen d-koppenhagen force-pushed the feat/prerender-content-dir-routes branch 2 times, most recently from c55ad72 to 1e8a3ac Compare January 15, 2024 05:08
@d-koppenhagen d-koppenhagen force-pushed the feat/prerender-content-dir-routes branch from 1e8a3ac to da83aff Compare January 15, 2024 18:04
@d-koppenhagen d-koppenhagen changed the title feat: pre-render content dir routes feat(vite-plugin-nitro): prerender content dir routes Jan 15, 2024
@brandonroberts brandonroberts merged commit 3b99b87 into analogjs:main Jan 16, 2024
23 checks passed
@brandonroberts
Copy link
Member

Thanks @d-koppenhagen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerender content routes based on files in directory
2 participants