-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vite-plugin-nitro): prerender content dir routes #833
feat(vite-plugin-nitro): prerender content dir routes #833
Conversation
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@d-koppenhagen I think this is on the right track. Will you check on the build failures? |
1ea744a
to
7f30913
Compare
✅ Deploy Preview for analog-ng-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4142d21
to
91b3e27
Compare
@brandonroberts I refactored it a bit and added also some more documentation and fixed the tests. It should now work as expected. |
@d-koppenhagen there are lots of files changed that aren't necessary for this PR. Any idea what happened there? |
I had run prettier as a GitHub action was red since formatting was not ok. |
bb1cc7b
to
7129395
Compare
I think a big part of the changed files are the ones of the blog demo app which I updated to demo the new feature here. |
e961de6
to
e58f29c
Compare
@brandonroberts sorry it took a while but now the build and format etc. is green. |
c55ad72
to
1e8a3ac
Compare
1e8a3ac
to
da83aff
Compare
Thanks @d-koppenhagen! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Closes #820
What is the new behavior?
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?