feat(vite-plugin-nitro): provide req and res to renderer #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR adds full req and res object from h3 to the analog event handler for app rendering closes analogjs#802
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brandonroberts
requested changes
Dec 19, 2023
packages/vite-plugin-nitro/src/lib/plugins/dev-server-plugin.ts
Outdated
Show resolved
Hide resolved
|
Looks great @Jefftopia! One small cleanup item on the interceptor naming |
|
Thanks! @allcontributors add @Jefftopia for code |
|
I've put up a pull request to add @Jefftopia! 🎉 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds full req and res object from h3 to the analog event handler for app rendering
closes #802
closes #586
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Current behavior is that the full, raw request and response are not provided to Analog, which limits the ability to use cookies from the incoming request.
Closes #802
What is the new behavior?
Now both the runtime renderer event handler and the nitro dev server have access to the request and response, which can then be provided to the application.
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?