Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): support Windows path for templateUrl and styleUrl #799

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

nemu69
Copy link
Contributor

@nemu69 nemu69 commented Dec 14, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #798

On Windows, path is: "C:UserProjectNameFrontsrcappapp.component.html?raw"

What is the new behavior?

Path is: "C:/User/ProjectName/Front/src/app/app.component.html?raw"

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

best describes this PR or how it makes you feel?

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 3405aaf
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/657b5ec5b2b09e0008b2d42c
😎 Deploy Preview https://deploy-preview-799--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 3405aaf
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/657b5ec5a97b430008ac067d
😎 Deploy Preview https://deploy-preview-799--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 3405aaf
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/657b5ec5c6bf5b00089955eb
😎 Deploy Preview https://deploy-preview-799--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts changed the title fix(vite-plugin-angular): support Windows path TemplateUrl and StyleU… fix(vite-plugin-angular): support Windows path for templateUrl and styleUrl Dec 14, 2023
@brandonroberts brandonroberts merged commit c083461 into analogjs:main Dec 14, 2023
16 checks passed
@brandonroberts
Copy link
Member

Thanks! @allcontributors add @nemu69 for code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Windows path TemplateUrl and StyleUrl on Vitest
2 participants