-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(trpc): allow install of superjson version 2.2.1 and newer #793
feat(trpc): allow install of superjson version 2.2.1 and newer #793
Conversation
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@goetzrobin @brandonroberts following up on this PR. Any concerns with this change? |
@jeremyhofer @brandonroberts I believe we can simply migrate to this new version instead of allowing both the old and the new. Thoughts? |
Updating solely to the 2.x version would work as well. I went with this approach initially since superjson is defined as a peer dependency and there are no compatibility issues between the 1.x and 2.x versions today. It would probably be more correct to allow any compatible 2.x version instead of requiring a version >=2.2.1, but that's the only 2.x version I've explicitly tested and know works. Brings the question - if we change to a 2.x version only do we want to consider changing superjson to be an actual dependency instead of a peer? Peer makes me think full flexibility and allow any versions that are compatible. If we change to a dependency then we can remove the overhead of maintaining the version in a project's package.json. |
I'm good with bumping to v2 if it's fully compatible. I think keeping it as a peer dep is fine and more generally preferred |
e1d244a
to
5ab2ef6
Compare
Just updated the branch to fully switch to v2. |
We should add a https://github.com/analogjs/analog/blob/main/packages/content/migrations/migration.json#L4 |
👍 Will get this added! |
5ab2ef6
to
8fb6159
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Currently superjson 1.x version >= 1.12.3 may be installed. Latest superjson version is 2.2.1, which - minus them internally changing to an esmodule package format - is backwards compatible with v1.
Releases: https://github.com/blitz-js/superjson/releases
Closes #
What is the new behavior?
Adds support for installing latest 2.x versions >= 2.2.1 in addition to 1.x versions.
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?