Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): remove caching of watched component templates #587

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Caching the template watchers causes issues when the component has multiple templateUrls

Closes #

What is the new behavior?

Page reloads happen when external templates are changed, whether it be single or multiple.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Caching the template watchers causes issues when the component has multiple templateUrls
@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit cd34d5c
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/64caa54fe2642e0008607ceb
😎 Deploy Preview https://deploy-preview-587--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit cd34d5c
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/64caa54fbc7d790008a21b54
😎 Deploy Preview https://deploy-preview-587--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit cd34d5c
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/64caa54f3f00a80008c9cff7
😎 Deploy Preview https://deploy-preview-587--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit fcc7aa4 into main Aug 2, 2023
@brandonroberts brandonroberts deleted the fix-watch-templates branch August 2, 2023 19:33
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant