Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-analog): restrain node 16 to 16.17. #533

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

JeanMeche
Copy link
Contributor

Using 16.18 & 16.19 breaks Analog, let's retrains the version to the latest working Node16: 16.17

Fixes #532

@netlify
Copy link

netlify bot commented Jul 9, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 4afd1e0
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/64aaf24b1389d20008fa94be
😎 Deploy Preview https://deploy-preview-533--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 9, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 4afd1e0
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/64aaf24b5671ce0007b07556
😎 Deploy Preview https://deploy-preview-533--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 9, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 4afd1e0
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/64aaf24b03ac200008a5a92a
😎 Deploy Preview https://deploy-preview-533--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JeanMeche JeanMeche force-pushed the fix/node16 branch 2 times, most recently from ba39ea6 to 26b1fce Compare July 9, 2023 17:16
@brandonroberts
Copy link
Member

This one should be updated also for the create-analog package.

https://github.com/analogjs/analog/blob/main/packages/create-analog/package.json

Using `16.18`/`16.19`  breaks Analog, Latest working Node16: `16.17`

Fixes analogjs#532
@brandonroberts brandonroberts changed the title fix(node): restrain node 16 to 16.17. fix(create-analog): restrain node 16 to 16.17. Jul 9, 2023
@brandonroberts brandonroberts merged commit cd099ad into analogjs:main Jul 9, 2023
@brandonroberts
Copy link
Member

@allcontributors add @JeanMeche for infra

@allcontributors
Copy link
Contributor

@brandonroberts

I've put up a pull request to add @JeanMeche! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: engines in create-analog should be updated to reflect compatible versions of Node
2 participants