Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trpc): make CreateTRPCProxyClient publicly available #453

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

goetzrobin
Copy link
Member

closes #447

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Type is private and cannot be used outside of @analogjs/trpc

Closes #447

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for analog-blog failed.

Name Link
🔨 Latest commit fc9e700
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/6482dd045143cc0008eda41c

@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit fc9e700
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/6482dd03cc647b0008da9d24
😎 Deploy Preview https://deploy-preview-453--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit fc9e700
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/6482dd03bb94600008c64835
😎 Deploy Preview https://deploy-preview-453--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@goetzrobin goetzrobin force-pushed the export-create-trpc-proxy-client branch from a7eea5d to fc9e700 Compare June 9, 2023 08:04
@brandonroberts brandonroberts changed the title fix(trpc): make CreateTRPCProxyClient publicly available feat(trpc): make CreateTRPCProxyClient publicly available Jun 9, 2023
@brandonroberts brandonroberts merged commit 8a432a9 into main Jun 9, 2023
@brandonroberts brandonroberts deleted the export-create-trpc-proxy-client branch June 9, 2023 12:34
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export the CreateTRPCProxyClient type to ease child-router type definitions
2 participants