-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): overhaul route discovery engine #444
feat(router): overhaul route discovery engine #444
Conversation
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
0e2f1c3
to
9feb102
Compare
Does this by any chance also fix #412 ? |
@markostanimirovic the router-discovery doesn't support two levels of nesting right?
I just started to try |
@brandonroberts it would be nice to have a command printing the detected routes somehow, |
@matheo routing nested in folders is supported. What do you mean by using dot notation inside nested folders? Any file with a .page.ts extension should be picked up. You can log the routes import { routes } from '@analogjs/router'; console.log(routes); |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Closes #237, #273
What is the new behavior?
Does this PR introduce a breaking change?
[optional] What gif best describes this PR or how it makes you feel?
EDIT: 😅