fix(vite-plugin-angular): apply babel transformations for safari 15 s… #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport in order to get analog apps working on safari versions 15.x on iOS to work we need to apply the babel transformations that enable compatibility correctly. this includes a fix in the supported browsers that expect an actual name of the browser and also the application of the babel transformation during optimization.
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
brandonroberts
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…upport
in order to get analog apps working on safari versions 15.x on iOS to work we need to apply the babel transformations that enable compatibility correctly. this includes a fix in the supported browsers that expect an actual name of the browser and also the application of the babel transformation during optimization.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
If you are on iOS 15, Analog applications do not work correctly.
Issue Number: N/A
What is the new behavior?
Analog works on iOS 15.
Does this PR introduce a breaking change?
Other information