Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): allow build-angular v15 #162

Merged
merged 1 commit into from
Nov 23, 2022
Merged

fix(vite-plugin-angular): allow build-angular v15 #162

merged 1 commit into from
Nov 23, 2022

Conversation

ilteoood
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-angular-plugin
  • astro-angular
  • create-analog
  • router

What is the current behavior?

The peer dependency @angular-devkit/build-angular supports only major version 14.

Issue Number: N/A

What is the new behavior?

The peer dependency @angular-devkit/build-angular should also support major version 15.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit eae8609
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/637e8861c5a1f60009878179
😎 Deploy Preview https://deploy-preview-162--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonroberts brandonroberts changed the title fix: allow build-angular v15 fix(vite-plugin-angular): allow build-angular v15 Nov 23, 2022
@brandonroberts brandonroberts merged commit 3e56717 into analogjs:main Nov 23, 2022
@brandonroberts
Copy link
Member

Thanks! @allcontributors add @ilteoood for code

@allcontributors
Copy link
Contributor

@brandonroberts

I've put up a pull request to add @ilteoood! 🎉

@ilteoood
Copy link
Contributor Author

@brandonroberts that was really quick, thanks!
May I ask you for a new release of the plugin?

@brandonroberts
Copy link
Member

Sure, all packages have been bumped and released

a2eab8e

Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants