Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS SD doesn't work on Windows #390

Closed
rgetz opened this issue Feb 27, 2020 · 5 comments
Closed

DNS SD doesn't work on Windows #390

rgetz opened this issue Feb 27, 2020 · 5 comments
Assignees
Milestone

Comments

@rgetz
Copy link
Contributor

rgetz commented Feb 27, 2020

As discussed in #388 - we don't support Win32 yet.

https://github.com/stammen/dnssd-uwp
has enough to make sure that Win10 would be supported (which I think is OK).

That would use these built in win10 features:
https://docs.microsoft.com/en-us/uwp/api/windows.networking.servicediscovery.dnssd

@adisuciu adisuciu self-assigned this Mar 18, 2020
@rgetz
Copy link
Contributor Author

rgetz commented Mar 29, 2020

I made a pull request #412 - let me know if we should merge that as is, or if you think you will have time to look at adding windows 10 support before then.

@rgetz
Copy link
Contributor Author

rgetz commented Mar 29, 2020

I guess the steps would be to create a dns_sd_win10.c, this would include things like:

  • a test for win10
  • dynamically load the dnssd-uwp DLL using LoadLibrary() & get pointers to the various dnssd functions
  • Create a dnssd service watcher using the above function
  • Which calls your callback which builds up the linked list, like the avahi and bonjour implementations do.
  • free everything when done.

I think that should be it. All the above code is under a MIT license - which means we can include it into libiio, we just need to point back, and make sure to include the appropriate copyrights in it.

@matejk
Copy link
Contributor

matejk commented Mar 30, 2020

Would it make sense to use an independent implementation like:

https://github.com/mjansson/mdns

@rgetz
Copy link
Contributor Author

rgetz commented Mar 30, 2020

Would it make sense to use an independent implementation like:

I don't think so - as much as it pains me - I don't think adding another library is worth it.

@rgetz rgetz added this to the 0.20 Release milestone Apr 16, 2020
@rgetz
Copy link
Contributor Author

rgetz commented May 20, 2020

This is being worked on as part of #508 , so closing this, as that (hopefully) will be merged soon.

@rgetz rgetz closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants