Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to pion/webrtc@v3 #451

Closed
Sean-Der opened this issue Dec 31, 2020 · 3 comments
Closed

Upgrade to pion/webrtc@v3 #451

Sean-Der opened this issue Dec 31, 2020 · 3 comments

Comments

@Sean-Der
Copy link
Contributor

Hey @anacrolix

We just released v3 and would love to help you upgrade if you are interested.

v3 enables Trickle ICE users may see faster connection times now. They can connect to others before STUN resolves. This is a breaking change so I will need to figure out how WebTorrent emits/receives candidates.
@Sean-Der Sean-Der mentioned this issue Dec 31, 2020
Closed
@anacrolix
Copy link
Owner

Yes, let's give it a try. I'm keen to see if the write size limit issue that came up when streaming with DataChannels has been fixed too.

@Sean-Der
Copy link
Contributor Author

Sean-Der commented Jan 2, 2021

The write size limit hasn't been fixed unfortunately. I don't even know how hard that would be to fix, let me look into that first. Hopefully I can come back to you with a dot release fixing that and then we can upgrade.

One annoyance is that it depends on remote support as well. Since the remote WebRTC peer may not support EOR you will still have to handle it.

@polarathene polarathene mentioned this issue Aug 30, 2021
Open
@anacrolix
Copy link
Owner

This was contributed by @Sean-Der in #470.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anacrolix @Sean-Der and others