SOCKS5 support for peer connections

[gen2brain]

Hi, I am still browsing through this package, I don't see a way to configure proxy. Can I do something with golang.org/x/net/proxy , I am interested in socks5 proxy.

Thanks

[anacrolix]

I don't currently have plans to implement socks support. I'll take any PRs, cheers.

[deranjer]

I looked into this a little bit since this is a feature I would like as well, where the code would need to be changed is here in client.go:

func (cl *Client) dialTCP(ctx context.Context, addr string) (c net.Conn, err error) {
	d := net.Dialer{
	// LocalAddr: cl.tcpListener.Addr(),
	}
	c, err = d.DialContext(ctx, "tcp", addr)
	countDialResult(err)
	if err == nil {
		c.(*net.TCPConn).SetLinger(0)
	}
	c = pproffd.WrapNetConn(c)
	return
}

Essentially we would replace the net.dialer with a proxy.dialer and pull the proxy from the config as a URL.

Unfortunately the proxy package does not currently support DialContext, I didn't look around to see if other proxy packages did support it. However, adding Context with proxy support is listed as expected in Go 1.11 in July 2018. Until this it is beyond my ability to investigate.

[anacrolix]

Thanks for looking into this. It looks like when this lands it'll be as simple as allowing a custom Dialer to be set for various Dials in the code base. If anyone needs this sooner, please recommend or refer us to an existing proxy implementation (that doesn't suck) that provides DialContext.

[anacrolix]

Could we create a Dialer that implicitly performs the DialContext underneath, and use that as the forward argument to golang.org/x/net/proxy.FromURL?

[anacrolix]

Here's an example of that kind of thing: https://github.com/anacrolix/missinggo/blob/master/reader_context.go

[anacrolix]

Take a look at #256

[anacrolix]

Proxy support has been added by @elgatito , see the ProxyURL field in the Config struct.

[anacrolix]

@gen2brain or anyone else following this thread: Are there any good socks5 client packages that support SOCKS5, and possibly UDP ASSOCIATE?

[anacrolix]

@elgatito I know you don't use this repo actively anymore, but do you know what would be required to support incoming connections over SOCKS? Would that be TCP BIND and UDP ASSOCIATE? The PR that you made allowed outgoing SOCKS connections? Do you know if it worked for UDP? Cheers

[anacrolix]

I've opened anacrolix/go-libutp#17, as I suspect go-libutp will require some extra configuration to support SOCKS.

[anacrolix]

Unfortunately the proxy package does not currently support DialContext, I didn't look around to see if other proxy packages did support it. However, adding Context with proxy support is listed as expected in Go 1.11 in July 2018.

@deranjer https://pkg.go.dev/golang.org/x/net/proxy#ContextDialer now exists. My limited understanding of SOCKS suggestions this is only the outgoing part. We still need special support to receive incoming connections.