Fixes to make dms work with Samsung TVs and UPnP Monkey on Android #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some parsers are picky about the order of elements in SOAP responses. It is recommended to follow the order given in the spec/wsdl. This change replaces the map used to pass the values back to the handler with a slice of 2-arrays, such that imposing an order is possible, and sorts the keys in the correct order. Verified with UPnP Monkey on Android, which before said: > ServerHandler: failure: org.fourthline.cling.model.action.ActionException: Current state of service prevents invoking that action. Error reading response message. Can't transform message payload: org.fourthline.cling.model.action.ActionException: The argument value is invalid. Wrong order of arguments, expected 'Result' not: TotalMatches..
If a childCount of 0 is reported, Samsung TVs never send a Browse request, and therefore no content is shown. This change is to report the proper value.
The DIDL-Lite specification requires that dc:title tags are the first child of their container. Samsung TVs are picky about this.
|
A very tidy PR, thank you! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make dms work on my Samsung TV, and while debugging against a very hackish Python script I wrote ages ago and which worked found some bugs related to other players as well 🙂 This PR is an attempt to fix them. Changes are:
Some XML parsers are picky about the order of elements, even in situations where a container only contains each tag exactly once. (I guess that allows an optimization in auto-generated parsers..) Since right now you use a
map[string]stringfor this, which is naturally unordered, I had to refactor some code to use[][2]stringinstead. The order I did use is the one in which the fields are introduced by the specification.dc:titletag firstThe specification requires that
item/containerDIDL-Lite tags have this tag as their first child. This is required for my Samsung TV.childCountfor containersAgain, my Samsung TV tries to be overly clever. Since dms reports 0 children, it doesn't bother to actually ever
Browsethe directory. (I am pretty certain that this is wrong and that 0 has some magic meaning, but couldn't find it - anyway, it doesn't harm to report the correct value here.)Let me know if there's anything you'd like to see changed.
By the way, thanks for writing and maintaining this application! It is really useful for setting up ad-hoc dlna servers 😄