Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define comment style #967

Open
lukasoppermann opened this issue Apr 27, 2023 · 4 comments
Open

Allow to define comment style #967

lukasoppermann opened this issue Apr 27, 2023 · 4 comments

Comments

@lukasoppermann
Copy link
Contributor

There is a commentStyle proper in the formatter, however it seems that at least in css this can not be overwritten: https://github.com/amzn/style-dictionary/blob/main/lib/common/formatHelpers/createPropertyFormatter.js#L52

Would be great if this option could be added: https://amzn.github.io/style-dictionary/#/formats?id=cssvariables

options.commentStyle could either be short or none ot it could be a boolean.

@dbanksdesign
Copy link
Member

I think that makes sense. It sounds like you are looking to turn off comments for specific files, maybe we expose that as an option on file configs?

@lukasoppermann
Copy link
Contributor Author

Exactly, I want to turn it off. Exposing it like this would be perfect.

@jorenbroekema
Copy link
Collaborator

b9270b2#diff-a8a4f9ccb2376c2ec73098072d8621be67c94e04cf9cc2e1b575a28aee5202e4R333 I added a feature for this, both in v3 and v4

@jorenbroekema
Copy link
Collaborator

Actually, it doesnt support "none", if you do that you might get #ffffff; undefined or something along those lines, should be easy to add though, PR welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants