Add options.outputStringLiterals to typescript/es6-declarations #857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: 905
Description of changes:
Problem:
Currently, the
typescript/es6-declarations
format assigns string tokens the typestring
. As a result, tokens are un-assignable to stricter types, such as string literal unions, without type assertion. The assignment of typestring
to tokens with string values does not align with Typescript's built-in type inference, which assigns string-literal types to string variables.Solution:
Add feature flag
options.outputStringLiterals
to thetypescript/es6-declarations
format's interface. If this boolean option is set to true, tokens with string values will be assigned string-literal types in the outputted files.Example (current):
Example with suggested change:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.