Make transitive transforms & resolves possible #371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #208
Transformations can only be executed, if the value to be transformed, has no references in it. So resolving may lead to enable further transformations, and sub sequent resolving may enable even more transformations - and so on.
Unfortunately the current implementation only transforms and resolves once, and transformation on values containing references do not work. This change enables this transitive dependencies, by executing "transform & resolve" until all transformations are executed.
Take the following example (the
color: {...}
object might setup your custom color transformation)As you can see
color.background.button.primary.hover
is a variation ofcolor.background.button.primary.base
which is a variation ofcolor.base.green
. This transitive dependencies are solved by running this loop.