Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(format): adding configurable name to sass map name #291

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Conversation

dbanksdesign
Copy link
Member

Issue #, if available: #290

Description of changes: Allowing configurable sass map names

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Collaborator

@chazzmoney chazzmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Is there an appropriate spot to add documentation? 😬

@dbanksdesign
Copy link
Member Author

There is... good point. I will add it in the JSDoc comments here:
https://github.com/amzn/style-dictionary/blob/master/lib/common/formats.js#L98

@dbanksdesign
Copy link
Member Author

And it looks like I already had a commit ready, take a look now. I didn't run the command to generate the docs, that will happen automatically in the next release.

@chazzmoney
Copy link
Collaborator

LGTM :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants