Fix: Add fallback for missing DPI-related Win32 APIs #629
+32
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amwx When you have a moment, I’d appreciate your review and any feedback you might have. Thanks a lot! |
amwx
requested changes
Dec 23, 2024
| { | ||
| return GetSystemMetricsForDpi(nIndex, dpi); | ||
| } | ||
| catch (EntryPointNotFoundException) |
There was a problem hiding this comment.
It would be better to use a Windows version check rather than Try/Catch. Take a look at the ApplyTheme method further below, as I already have a helper class for this.
There was a problem hiding this comment.
@amwx I have used the helper class you provided for the check. However, I found an issue with the function: it returns false instead of true when the system version exactly matches the major, minor, and build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #628