Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add comma between bigquery requirements listings #452

Merged

Conversation

madison-ookla
Copy link
Contributor

Summary of Changes

This PR fixes an issue wherein this package could not be installed with the bigquery extra because a comma was missing between two package specifications. Python allows this as a multi-line string, so both requirements are concatenated and neither can be found.

Resolves amundsen-io/amundsen#938

Tests

No tests were modified

Documentation

No documentation needed to be changed, this was a change to align with expected behavior.

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Copy link
Member

@feng-tao feng-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, could you fix the DCO? thanks

@madison-ookla madison-ookla force-pushed the bugfix/bigquery-versions branch from e3e034a to 781ca2f Compare March 2, 2021 19:42
@feng-tao feng-tao merged commit 027edb9 into amundsen-io:master Mar 2, 2021
@madison-ookla madison-ookla deleted the bugfix/bigquery-versions branch March 2, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid pip version syntax
2 participants