Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dashboard chart in search #383

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Conversation

feng-tao
Copy link
Member

@feng-tao feng-tao commented Oct 15, 2020

Signed-off-by: feng-tao [email protected]

Summary of Changes

Support searching chart name in dashboard search.

subject:
Search dashboards by chart name

feature-summary:
Be able to search for dashboards by chart names (similar to Groups).

value-prop:
Assuming reasonable chart naming, this would be a proxy for "search by metric" without needing to build anything new, manually tag, or add any incremental work for dashboard creators. It will also be a cleaner way to identify multiple sources of reporting on the same or similar items, especially if they're included in "large, generically-named functional dashboards with a lot of charts" where just searching names doesn't pull them both up.

Tests

test locally and lyft staging

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: feng-tao <[email protected]>
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: feng-tao <[email protected]>
@feng-tao feng-tao merged commit 6cced36 into master Oct 15, 2020
@feng-tao feng-tao deleted the tfeng_add_chart_to_es branch October 15, 2020 18:31
Wonong pushed a commit to Wonong/amundsendatabuilder that referenced this pull request Oct 16, 2020
* feat: support dashboard chart in search

Signed-off-by: feng-tao <[email protected]>

* feat: fix lint

Signed-off-by: feng-tao <[email protected]>

* update

Signed-off-by: feng-tao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants