Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'd' problem on translation #155

Merged
merged 4 commits into from
Jun 28, 2013
Merged

Fix 'd' problem on translation #155

merged 4 commits into from
Jun 28, 2013

Conversation

marcialca
Copy link
Contributor

Since in spanish you use 'de' to say 'of' it gets mistaken for a d in the date format. An easy way to fix this is to use 'De' with capital D so it doesn't get mistaken. It's better to have a misplaced capital letter to a useless date name (the dates get rendered as "Domingo 22 22e Junio 22e 2013" instead of "Domingo 22 de Junio de 2013"

Since in spanish you use 'de' to say 'of' it gets mistaken for a d in the date format. An easy way to fix this is to use 'De' with capital D so it doesn't get mistaken. It's better to have a misplaced capital letter to a useless date name (the dates get rendered as "Domingo 22 22e Junio 22e 2013" instead of "Domingo 22 de Junio de 2013"
@marcialca
Copy link
Contributor Author

I also tried to scape the letter 'd' with / but it didn't work

@brunogaspar
Copy link

I think the proper fix is to have it like this format: 'dddd d d!e mmmm d!e yyyy', notice the ! on the de at least, is what it's on the documentation, http://amsul.ca/pickadate.js/date.htm#formats

@marcialca
Copy link
Contributor Author

Oh, it looks like I missed that part of the docs. Sorry about that. In that case I'll make the fix and make the pull request again if you want

@brunogaspar
Copy link

It's cool :)

While you are at it, do you mind doing the same on the Portuguese and Portuguese/Brazilian ones? They are pretty much the same i believe

@marcialca
Copy link
Contributor Author

Ok, no problem :)

Marcial Cambronero
http://marcialcambronero.com

On Sun, Jun 23, 2013 at 10:43 PM, Bruno Gaspar [email protected]:

It's cool :)

While you are at it, do you mind doing the same on the Portuguese and
Portuguese/Brazilian ones? They are pretty much the same i believe


Reply to this email directly or view it on GitHubhttps://github.com//pull/155#issuecomment-19888866
.

Scaping the 'd' letter on the format for Spanish
Scaping the 'd' letter on the format for PT
Scaping the 'd' letter on the format for PT
@amsul
Copy link
Owner

amsul commented Jun 28, 2013

@brunogaspar, you’re awesome! Thanks for pointing @marcialca in the right direction.

@marcialca I’ve locally merged your fix into the appropriate branch (dev) and will push it soon :)

amsul added a commit that referenced this pull request Jun 28, 2013
@amsul amsul merged commit 0dcb4cc into amsul:gh-pages Jun 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants