Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Bluebird with native promises #627

Closed
kibertoad opened this issue May 17, 2021 · 4 comments
Closed

Replace Bluebird with native promises #627

kibertoad opened this issue May 17, 2021 · 4 comments

Comments

@kibertoad
Copy link
Collaborator

As Matteo Collina once said, "The first rule of Node.js performance optimization is to remove bluebird" (https://twitter.com/matteocollina/status/1351949461371686914)

Considering that support for older Node versions was dropped, it should be fairly straightforward to adjust current implementation to fully utilize native promises instead.

If there is approval for this change, I can provide a PR implementing it.

@jimmywarting
Copy link
Contributor

👍
Drop support for older node version, safe-buffer can be replaced with buffer from node

@kibertoad
Copy link
Collaborator Author

PR for this was already up: #624

@carlhoerberg
Copy link
Contributor

https://github.com/cloudamqp/amqp-client.js/ is a newer AMQP library that uses native promises (along with other improvements)

@cressie176
Copy link
Collaborator

[email protected] uses native promises

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants