Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open source storybook-addon-amp #57

Closed
wassgha opened this issue May 19, 2020 · 9 comments
Closed

Open source storybook-addon-amp #57

wassgha opened this issue May 19, 2020 · 9 comments

Comments

@wassgha
Copy link

wassgha commented May 19, 2020

image

Request to spin off the storybook AMP addon (currently living under build-system/tasks/storybook/amp-env) as a standalone repository (ampproject/storybook-addon-amp) and publish it on npm as storybook-addon-amp.

This allows:

  • AMP can now simply import { withAmp } from "storybook-addon-amp" instead of using a long relative path to the addon
  • Separate storybook dependencies from the addon's specific dependencies inside the amphtml repository
  • Provide outside projects with a way to render AMP components inside storybook
  • Provide a natural place for documentation of the usage of the addon
@wassgha
Copy link
Author

wassgha commented May 19, 2020

@ampproject/tsc @ampproject/wg-ui-and-a11y

@cramforce
Copy link
Member

Good idea

@wassgha
Copy link
Author

wassgha commented May 19, 2020

Can someone guide us though the aproval process and creating a repository under ampproject/

@cramforce
Copy link
Member

So, far this is still the google launch process for OSS projects (pending switch over to the foundation)

@dvoytenko
Copy link

Since the switch to the foundation is over, let's approve this here.

Approved from me. Still need 2 more approvers from @ampproject/wg-approvers

@cramforce
Copy link
Member

LGTM2

@rsimha
Copy link

rsimha commented Jul 20, 2020

LGTM3. Glad to see this grow into a standalone piece of infrastructure.

@mrjoro
Copy link
Member

mrjoro commented Jul 20, 2020

Great! I've created https://github.com/ampproject/storybook-addon-amp and made @wassgha , @dvoytenko and @kristoferbaxter admins. :)

@kristoferbaxter
Copy link
Contributor

Closing since this has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants