Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use renovate to auto-update Node versions in package.json files #25209

Closed
rsimha opened this issue Oct 22, 2019 · 5 comments · Fixed by #26427
Closed

Use renovate to auto-update Node versions in package.json files #25209

rsimha opened this issue Oct 22, 2019 · 5 comments · Fixed by #26427
Assignees
Labels
Type: Feature Request WG: Caching: Triaged Initial triage from wg-caching complete. Remove label if new input required. WG: caching WG: infra

Comments

@rsimha
Copy link
Contributor

rsimha commented Oct 22, 2019

We've had to periodically update the engines section of our package.json files each time a new version of Node is released. Sometimes, this breaks Travis builds. And at other times, it breaks tools like amphtml-validator.

See #25161 (comment) for a discussion on this.

I propose that we configure Renovate to keep the engines section in all our package.json files up to date. Here are the docs: https://docs.renovatebot.com/node. I think a support policy of active should give us what we're looking for.

@rsimha
Copy link
Contributor Author

rsimha commented Oct 22, 2019

Tagging @ampproject/wg-infra @ampproject/wg-caching @ampproject/wg-runtime @ampproject/wg-performance in case someone can think of a reason not to do this.

@estherkim since you just fixed this for amphtml and validator, can I assign this to you?

@twifkak
Copy link
Member

twifkak commented Oct 22, 2019

I suggest lts instead of active. Note that in the future there will be only a two day overlap between the "active" status of v12 and v14, which would give people insufficient time to upgrade. (If I'm reading that right...)

edit: Or maybe ['lts', 'active'] to match what was just deployed in #25208.

@rcebulko
Copy link
Contributor

This seems reasonable, especially for minor and patch upgrades

@rsimha
Copy link
Contributor Author

rsimha commented Oct 24, 2019

I had a déjà vu moment and realized that we've already attempted this before: See #19218. Not sure if it doesn't work, or if it hasn't had to do anything thus far. Will need to dig into this some more.

@rsimha
Copy link
Contributor Author

rsimha commented Oct 24, 2019

And here's the long discussion we had when node version 8 gave way to 10: #19050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request WG: Caching: Triaged Initial triage from wg-caching complete. Remove label if new input required. WG: caching WG: infra
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants