-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use renovate
to auto-update Node versions in package.json
files
#25209
Comments
Tagging @ampproject/wg-infra @ampproject/wg-caching @ampproject/wg-runtime @ampproject/wg-performance in case someone can think of a reason not to do this. @estherkim since you just fixed this for amphtml and validator, can I assign this to you? |
I suggest edit: Or maybe |
This seems reasonable, especially for minor and patch upgrades |
I had a déjà vu moment and realized that we've already attempted this before: See #19218. Not sure if it doesn't work, or if it hasn't had to do anything thus far. Will need to dig into this some more. |
And here's the long discussion we had when node version 8 gave way to 10: #19050 |
We've had to periodically update the
engines
section of ourpackage.json
files each time a new version of Node is released. Sometimes, this breaks Travis builds. And at other times, it breaks tools likeamphtml-validator
.See #25161 (comment) for a discussion on this.
I propose that we configure Renovate to keep the
engines
section in all ourpackage.json
files up to date. Here are the docs: https://docs.renovatebot.com/node. I think a support policy ofactive
should give us what we're looking for.The text was updated successfully, but these errors were encountered: