Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

AMP Bench warns about If-Modified-Since as not supported, but it is #118

Open
xavierleune opened this issue Jun 18, 2019 · 0 comments
Open

Comments

@xavierleune
Copy link

Hi,

I think there is an error about "if-modified-since" validation.
As far as I understand, ampbench is searching for a response header "if-modified-since" to mark the status as passed, but if-modified-since is only a request header, so this check does not make any sense.

You can reproduce this issue with the following url: https://www.journaldunet.com/economie/transport/1439209-uber-blablalines-assistant-sncf-agregateur-mobilites/

A better way to validate the if-modified-since support is to check the cachability response headers + the Last-Modified header.

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant