Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosted Zone name matching broken in v7.3.1 #607

Closed
jormaechea opened this issue Dec 5, 2023 · 2 comments · Fixed by #609
Closed

Hosted Zone name matching broken in v7.3.1 #607

jormaechea opened this issue Dec 5, 2023 · 2 comments · Fixed by #609
Labels

Comments

@jormaechea
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Bug Report

Error Description
Custom domain creation fails when the hosted zone and the domain are the same.

For example, if an API has the domain api.example.com and the hosted zone is api.example.com..

The following error is thrown: Could not find hosted zone 'api.example.com'

This bug has been introduced in v7.3.1; it works OK in v7.3.0

Command Run
sls create_domain

Console Output

Error: Unable to create domain '[REDACTED]':
Could not find hosted zone '[REDACTED]'
    at ServerlessCustomDomain.<anonymous> (/[REDACTED]/node_modules/serverless-domain-manager/dist/src/index.js:258:23)
    at Generator.throw (<anonymous>)
    at rejected (/[REDACTED]/node_modules/serverless-domain-manager/dist/src/index.js:6:65)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Domain Manager Configuration
Replace this with your own serverless.yml file (anonymized, of course) to help us better resolve your issue.

custom:
  customDomain:
    domainName: api.example.com
    createRoute53Record: true

Versions

  • Domain Manager version(s): v7.3.1
  • Node/npm version: Node 18
  • Serverless Version: v3.38
  • Lambda Code Javascript

Possible Solution

Additional context/Screenshots

@jormaechea jormaechea added the bug label Dec 5, 2023
@jormaechea
Copy link
Author

Caused by #606

This was referenced Dec 7, 2023
@jormaechea
Copy link
Author

Thanks @rddimon! 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant