Issue with serverless 1.61.2

[mlecoq]

Hi,

it may be an issue on serverless side. When I try to deploy my app with sls 1.61.1 all is fine but with 1.61.2 I have the following error :

Serverless Domain Manager: ConfigError: Missing region in config
 
  Error --------------------------------------------------
 
  Error: Error: Failed to find CloudFormation resources for dev.ws.archireport.com
  
      at ServerlessCustomDomain.<anonymous> (/root/repo/node_modules/serverless-domain-manager/dist/index.js:558:23)
      at Generator.throw (<anonymous>)
      at rejected (/root/repo/node_modules/serverless-domain-manager/dist/index.js:5:65)
      at processTicksAndRejections (internal/process/task_queues.js:94:5)
  From previous event:
      at PluginManager.invoke (/usr/local/share/.config/yarn/global/node_modules/serverless/lib/classes/PluginManager.js:490:22)
      at /usr/local/share/.config/yarn/global/node_modules/serverless/lib/classes/PluginManager.js:525:24
  From previous event:
      at PluginManager.run (/usr/local/share/.config/yarn/global/node_modules/serverless/lib/classes/PluginManager.js:525:8)
      at /usr/local/share/.config/yarn/global/node_modules/serverless/lib/Serverless.js:133:33
      at processImmediate (internal/timers.js:439:21)
      at process.topLevelDomainCallback (domain.js:130:23)

Here is my config

custom:
    customDomain:
        domainName: '${self:provider.stage}.ws.archireport.com'
        basePath: changeEvents
        stage: '${self:provider.stage}'
        createRoute53Record: true

If you think that it's an issue related to sls, I will open one on sls side

[turakvlad]

@mlecoq, hello!

I am not sure but it looks like it is related to https://github.com/serverless/serverless. Everything works fine for me in 1.61.1, but this patch update to 1.61.2 broke the plugin for me as well.

I opened the issue there - serverless/serverless#7225.

If you want you can confirm there that you have the same issue.

[chearmstrong]

They responded...

@turakvlad with v1.61.2 we've fixed one internal issue, and it appears that domain manager relied on that specific quirk of a framework (which technically was buggy design).

Issue ideally should be fixed in domain manager plugin

[hasan-sf]

Reverting to 1.61.0 is a temp solution that works for in the meantime, that is,
npm install -g [email protected]

[medikoo]

Internal method in Serverless framework getCredentials no longer resolves region (fact that it did, introduced other issues, and was not great in terms of separation of concerns).

I've proposed a (backward compatible) patch at #307 to keep plugin aligned

[turakvlad]

@medikoo , thank you!

Now let's wait when someone approves and merges it.