Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-proposal] never mind #1362

Closed
orgua opened this issue Jan 22, 2024 · 1 comment
Closed

[feature-proposal] never mind #1362

orgua opened this issue Jan 22, 2024 · 1 comment
Assignees

Comments

@orgua
Copy link

orgua commented Jan 22, 2024

No description provided.

@orgua orgua changed the title [feature] streamline module-structure [feature-proposal] streamline module-structure Jan 23, 2024
@Nytelife26
Copy link
Member

I like where this is going so far. Here are my additional proposals for the check structure

Out of scope considerations: cursing, security, links, spelling. Each has merits, but they feel out of place in the context of the goal of proselint.

Condensing considerations:

  • lgbtq, sexism and similar can be combined. This category might be named something like social_awareness
  • airlinese, corporate_speak and similar can be combined. This category might be named something like industrial_language. Optionally, jargon may be added to this.
  • mondegreens and malapropisms are commonly grouped together in analysis.
  • Punctuation spacing and typography should be together, too. Spacing is a purely typographic matter.

I also liked your previous suggestion of flattening categories with only one file. It might be worth making a standard for check naming, while we're at it.

Let me know what you think.

@Nytelife26 Nytelife26 self-assigned this Feb 5, 2024
@Nytelife26 Nytelife26 added this to the 1.0.0 milestone Apr 23, 2024
@orgua orgua changed the title [feature-proposal] streamline module-structure [feature-proposal] never mind May 28, 2024
@orgua orgua closed this as completed May 28, 2024
@Nytelife26 Nytelife26 removed this from the Refactoring (launch of 1.0.0) milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants