Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use iobuffer instead of string for streaming files #22

Merged
merged 1 commit into from
Jan 3, 2015
Merged

use iobuffer instead of string for streaming files #22

merged 1 commit into from
Jan 3, 2015

Conversation

yeesian
Copy link
Contributor

@yeesian yeesian commented Jan 3, 2015

replace string concatenation in src/streaming.jl with IOBuffer

replace string concatenation in `src/streaming.jl` with IOBuffer
@yeesian
Copy link
Contributor Author

yeesian commented Jan 3, 2015

Here's the performance difference when parsing OSM files:

(previously)

julia> @time nodes, highways, buildings, features = getOSMData(filename, true);
elapsed time: 627.010413888 seconds (176812171176 bytes allocated, 89.00% gc time)

(after the PR)

julia> @time nodes, highways, buildings, features = getOSMData(filename, true);
elapsed time: 85.566212155 seconds (10574148240 bytes allocated, 65.05% gc time)

amitmurthy added a commit that referenced this pull request Jan 3, 2015
use iobuffer instead of string for streaming files
@amitmurthy amitmurthy merged commit e03f03c into JuliaIO:master Jan 3, 2015
@amitmurthy
Copy link
Collaborator

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants