Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaking Memory #17

Closed
Presheda opened this issue Apr 1, 2020 · 5 comments
Closed

Leaking Memory #17

Presheda opened this issue Apr 1, 2020 · 5 comments

Comments

@Presheda
Copy link

Presheda commented Apr 1, 2020

Leak Canary reported that the OnDayPickedListener() is causing a memory leak.
is there a way to remove the listener when i no longer need it.
@aminography
Copy link
Owner

Sure. I'll provide it in the next version. Thanks for reporting the issue.

@Presheda
Copy link
Author

Presheda commented Apr 1, 2020

That will be great. Thank you.

@aminography
Copy link
Owner

aminography commented Apr 11, 2020 •
edited
Loading

Please update the library to version 2.0.0 then use datePicker.setDayPickCallback(null).
Some basic changes have happened in this version. You can see how to create the PrimeDatePickerBottomSheet in DatePickerActivity.kt.

@Presheda
Copy link
Author

Could you please give a Java doc ?

@aminography
Copy link
Owner

aminography commented Apr 17, 2020 •
edited
Loading

Yes, sure, soon. Moved to #29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aminography @Presheda