Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made benchmarks runnable #116

Merged
merged 1 commit into from
Mar 10, 2017
Merged

Made benchmarks runnable #116

merged 1 commit into from
Mar 10, 2017

Conversation

WaDelma
Copy link
Member

@WaDelma WaDelma commented Mar 10, 2017

I tried to run benchmarks and noticed that they don't work:

  • bitsets were moved to different place, were private and didn't have documentations
  • There were mutability problems with bunch of benchmarks.

After fixing these, benchmarks work, but create_now test panics:

test world::create_now              ... thread 'main' panicked at 'index out of bounds: the len is 1024 but the index is 1024', src\libcollections\vec.rs:1401
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
   0: specs::world::Allocator::allocate
   1: <specs::world::World<C>>::create_now
   2: benches::world::create_now
   3: test::run_test
   4: test::run_tests
   5: test::run_tests_console
   6: test::test_main
   7: test::test_main_static
   8: benches::__test::main
   9: std::panicking::try::do_call
  10: __rust_maybe_catch_panic
  11: std::rt::lang_start
  12: main
  13: __tmainCRTStartup
  14: unit_addrs_search
  15: unit_addrs_search

@kvark
Copy link
Member

kvark commented Mar 10, 2017

Thank you! We've got to figure out why it panics.

@kvark kvark merged commit b6297d1 into amethyst:master Mar 10, 2017
xMAC94x pushed a commit to xMAC94x/specs that referenced this pull request Mar 10, 2021
116: Even more cleanup r=torkleyy a=torkleyy

Fixes amethyst#111 

Co-authored-by: Thomas Schaller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants