Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fetchye): support headers as a function #86

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

code-forger
Copy link
Member

Description

Support a way of passing 'dynamic headers'

Motivation and Context

This allows some headers to be created at the time the api call is actually made, including when the run function is called.

This significantly reduces the boiler plate required to otherwise achieve this functionality.

How Has This Been Tested?

Unit tests
No existing tests failing proves this is fully backwards compatible

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Fetchye?

New feature

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 520cd97:

Sandbox Source
quick-install Configuration
fetchye-provider-install Configuration
fetchye-redux-provider-install Configuration
nextjs-fetchye-ssr Configuration

@code-forger code-forger requested a review from a team October 11, 2023 12:16
README.md Outdated Show resolved Hide resolved
@10xLaCroixDrinker 10xLaCroixDrinker merged commit cd4c175 into main Oct 20, 2023
4 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feat/dynamic-headers branch October 20, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants