[ament_lint_auto] General file exclusion with AMENT_LINT_AUTO_FILE_EXCLUDE #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er hook This commit allows the ament_cmake_uncrustify linter hook to abide to ament_lint_auto conventions by passing the AMENT_LINT_AUTO_FILE_EXCLUDE list variable to ament_uncrustify's file exclusion argument. Signed-off-by: Abrar Rahman Protyasha <[email protected]>
… hook This commit allows the ament_cmake_cppcheck linter hook to abide to ament_lint_auto conventions by passing the AMENT_LINT_AUTO_FILE_EXCLUDE list variable to ament_cppcheck's file exclusion argument. Signed-off-by: Abrar Rahman Protyasha <[email protected]>
…r hook This commit allows the ament_cmake_copyright linter hook to abide to ament_lint_auto conventions by passing the AMENT_LINT_AUTO_FILE_EXCLUDE list variable to ament_copyright's file exclusion argument. Signed-off-by: Abrar Rahman Protyasha <[email protected]>
…hook This commit allows the ament_cmake_cpplint linter hook to abide to ament_lint_auto conventions by passing the AMENT_LINT_AUTO_FILE_EXCLUDE list variable to ament_cpplint's file exclusion argument. Signed-off-by: Abrar Rahman Protyasha <[email protected]>
Signed-off-by: Abrar Rahman Protyasha <[email protected]>
|
@methylDragon pinging for a review! |
|
methylDragon
approved these changes
Jun 13, 2022
This was referenced Mar 16, 2023
|
@Mergifyio backport humble |
✅ Backports have been created
|
clalancette
pushed a commit
that referenced
this pull request
Jul 17, 2023
…CLUDE (#386) (#445) (cherry picked from commit 2ed2e93) Co-authored-by: Abrar Rahman Protyasha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no interface to specify a file exclusion list for linters invoked through ament_lint_auto, and as such each linter needs to be provided with duplicates of a common file exclusion list.
As discussed in #343, it is reasonable to expect that linters registering themselves as ament_lint_auto extensions should abide to ament_lint_auto conventions in doing so. Namely, linter hooks should abide to the CMake list variable
AMENT_LINT_AUTO_FILE_EXCLUDEwhich will propagate a file exclusion list to each linter invoked by ament_lint_auto.Closes #343.
Signed-off-by: Abrar Rahman Protyasha [email protected]