Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to exclude packages in ament_execute_extensions: #165

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

jpsamper2009
Copy link
Contributor

@tfoote tfoote added the in review Waiting for review (Kanban column) label Apr 4, 2019
@dirk-thomas
Copy link
Contributor

Unfortunately my changes (823e5b8) don't pass the DCO check. Can you please squash both commits?

- This provides a mechanism for 'ament-auto' packages to have
their own exclude options

Signed-off-by: Juan Pablo Samper <[email protected]>
@jpsamper2009 jpsamper2009 force-pushed the ament-lint-auto-exclude branch from 823e5b8 to efc52af Compare April 5, 2019 17:26
@jpsamper2009
Copy link
Contributor Author

@dirk-thomas Done. Back to you

@dirk-thomas dirk-thomas added the enhancement New feature or request label Apr 5, 2019
@dirk-thomas dirk-thomas merged commit b6a5a35 into ament:master Apr 5, 2019
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Apr 5, 2019
nuclearsandwich pushed a commit to ros/class_loader that referenced this pull request Apr 12, 2019
- This serves as an example for the EXCLUDE option of
ament_lint_auto_find_test_dependencies, allowing to
exclude the default ament_copyright configuration and
running with a custom configuration
- See ament/ament_lint#133 and ament/ament_cmake#165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants