Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc touchups 5 #447

Merged
merged 6 commits into from
Jun 19, 2024
Merged

Misc touchups 5 #447

merged 6 commits into from
Jun 19, 2024

Conversation

keyserj
Copy link
Collaborator

@keyserj keyserj commented Jun 19, 2024

Description of changes

Additional context

nodes added via context menu weren't having text selected properly
Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for ameliorate-docs canceled.

Name Link
🔨 Latest commit f157c9b
🔍 Latest deploy log https://app.netlify.com/sites/ameliorate-docs/deploys/66723c5de250cf0008a23a43

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for velvety-vacherin-4193fb ready!

Name Link
🔨 Latest commit f157c9b
🔍 Latest deploy log https://app.netlify.com/sites/velvety-vacherin-4193fb/deploys/66723c5ecbaded00083cc8ae
😎 Deploy Preview https://deploy-preview-447--velvety-vacherin-4193fb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 52
Accessibility: 86
Best Practices: 92
SEO: 85
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

keyserj added 5 commits June 18, 2024 21:03
seems like a good practice to ensure the same versions
are being used across machines.
nice to be able to do like "solution - [solution name]"
shouldn't update url if the changed view wasn't selected
more performant but also simpler logic.

previously (solution -> has component -> creates benefit
-> addresses detriment -> created by problem) would have both a
solution descendant and problem ancestor, so it wouldn't
be given a partition, which is not ideal.
@keyserj keyserj merged commit 8888854 into main Jun 19, 2024
13 checks passed
@keyserj keyserj deleted the misc-touchups-5 branch June 19, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant