Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No indication that table is being filtered #202

Closed
keyserj opened this issue Aug 23, 2023 · 1 comment
Closed

No indication that table is being filtered #202

keyserj opened this issue Aug 23, 2023 · 1 comment
Labels
bug Something isn't working criteria table improves the criteria table not sure if worth not sure if this is worth implementing yet QoL small change the improves the feel of using the tool

Comments

@keyserj
Copy link
Collaborator

keyserj commented Aug 23, 2023

Describe the bug
When I add a filter, if I hide it, there's no indication of the table being filtered:
chrome_2023-08-23_11-11-58

If I'm working with a filter for a while, this can be annoying, but it'll get worse if we persist filters, because I'll forget if I was using one. I could leave the filter showing the whole time, but if I'm filtering many nodes, the filter takes up a lot of the screen, and that's annoying too.

To Reproduce
Steps to reproduce the behavior:

See video above

Expected behavior
Ideally, there'd be a little icon or something to show if there's filtering happening. The table library we're using actually does have this:
image
but we're disabling it because it would awkwardly outside of the node in the cell.

Screenshots

Additional context

Technical ideas

  • maybe we could remove the node box from the cell, putting all the node data directly in the cell
  • maybe we could use a different icon for the filter in the table toolbar, if the filter is hidden but there's a filter being used
@keyserj keyserj added bug Something isn't working criteria table improves the criteria table QoL small change the improves the feel of using the tool labels Aug 23, 2023
@keyserj keyserj added this to the update #2 milestone Aug 23, 2023
@keyserj keyserj removed this from the update #3: improving discourse milestone Dec 19, 2023
@keyserj keyserj added the not sure if worth not sure if this is worth implementing yet label May 15, 2024
@keyserj
Copy link
Collaborator Author

keyserj commented Jul 29, 2024

made it clear how to find if it's filtering in #325
potentially could add more indication but it doesn't seem like as big of a deal as it was

@keyserj keyserj closed this as completed Jul 29, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in ameliorate Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working criteria table improves the criteria table not sure if worth not sure if this is worth implementing yet QoL small change the improves the feel of using the tool
Projects
Status: Done
Development

No branches or pull requests

1 participant